Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.1] Fix possible key overlap in cache of Str::snake #13943

Merged
merged 1 commit into from
Jun 11, 2016
Merged

[5.1] Fix possible key overlap in cache of Str::snake #13943

merged 1 commit into from
Jun 11, 2016

Conversation

vlakoff
Copy link
Contributor

@vlakoff vlakoff commented Jun 10, 2016

Not a very practical example, but this PR avoids such a collision:

Str::snake('foo', '--');
Str::snake('foo-', '-');

@vlakoff
Copy link
Contributor Author

vlakoff commented Jun 10, 2016 •
edited
Loading

Mmmm, a bit unsure, is it okay to target 5.1?

@GrahamCampbell
Copy link
Member

I think this was changed in a later version? Also, we defintely need tests with this please.

@GrahamCampbell
Copy link
Member

Oh, right I see. Just read this again. We've not fixed this in a later version.

@vlakoff
Copy link
Contributor Author

vlakoff commented Jun 10, 2016

Added tests.

@taylorotwell taylorotwell merged commit 4c4313c into laravel:5.1 Jun 11, 2016
@vlakoff vlakoff deleted the str-snake branch June 13, 2016 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vlakoff @GrahamCampbell @taylorotwell