[5.1] Do not allow empty cache paths #14291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| */ | ||
| public function __construct(Filesystem $files, $cachePath) | ||
| { | ||
| if (! $cachePath) { | ||
| throw new InvalidArgumentException('The cache path must be non-empty.'); |
There was a problem hiding this comment.
"non-empty" might be ambiguous in this context.
There was a problem hiding this comment.
I think it's ok. false and null are "empty" in php.
There was a problem hiding this comment.
I meant because it's referring to a path which might be empty (not contain any files).
There was a problem hiding this comment.
Indeed, one of these may be better:
The cache path must be a non-empty value.The cache path must not be an empty value.
There was a problem hiding this comment.
It's been changed in d9ed009
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #14277. Closes #14271.