[5.3] Use \Doctrine\DBAL\Driver\PDOConnection if available #14363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -3,6 +3,7 @@ | |||
| namespace Illuminate\Database\Connectors; | |||
|
|
|||
| use PDO; | |||
| use Doctrine\DBAL\Driver\PDOConnection; | |||
If doctrine/dbal is installed the PDOConnection class provided by the package should be used instead of just PDO. Else e.g. detecting the database version doesn't work.
This was referenced Jul 19, 2016
|
Is this fix still working? I want to rename a column in a table with a json column but throws me the error:
Even it doesn't let me change any column... |
|
Looks like DBAL doesn't support the JSON type for MySQL yet (see here). It should work with PostgreSQL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #14359 to target the 5.3 branch.