[5.2] Tests for Arr::get()/has() with exact key containing dot #15010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great, I managed to make the Travis CI tests to disappear |
|
Tests are failing now? |
| $array = ['products.desk' => ['price' => 100]]; | ||
| $this->assertTrue(Arr::has($array, 'products.desk')); | ||
| $this->assertTrue(Arr::has($array, ['products.desk'])); | ||
| $this->assertFalse(Arr::has($array, ['products.desk', 'missing'])); |
There was a problem hiding this comment.
In 5.2 the second argument to has should be a string or an integer, not an array. Arrays were supported in 5.3 only.
@taylorotwell that's why the build fails.
|
How can we fix the build? |
|
@taylorotwell fixed the tests here #15015 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arr::has()introduced in 5.3, in [5.3] Fix in Arr::has to check for exact key first #14976. Better be safe.Arr::get(), which should be merged into 5.3 as well.ping @themsaid :)