[5.3] Revert Eloquent builder changes on firstOr* functions to fix bug #15018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamCampbell
changed the title
|
Probably needs backporting to 5.2, and a final 5.2 release happening. |
|
@GrahamCampbell Yeah, I agree it should be backported to 5.2 as it was a breaking change introduced in 5.2 which wasn't documented. This overall implementation worked, but it broke existing use of the function depending on how the function was used. |
|
Ok, I've backported this. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts the changes made in PR #14656 & Issue #14649, which broke the firstOr* functions in certain scenarios. They started returning either a new instance if the DB was empty or the first row if anything existed depending on what your mutators did. This is fine, but it's a breaking change that should be applied and documented appropriately.