[5.2] Fixed issue introduced on reverting previous aggregate functions #15150
Conversation
A change to the query builder sum function introduced issues where the sum function would return values other than of numeric type.
|
We intentionally reverted this to match the old behaviour. This breaking change will be moved to 5.3 or 5.4 if at all. |
GrahamCampbell
changed the title
|
@GrahamCampbell But from what I can tell, the old behaviour for the sum method had a "return $result ?? 0;" before commit 73ee91b on the 12th August, ensuring it always returned a numeric value. This was also stated in the original PHP Doc defined for the sum method, which should return a float|int. This has now gone which breaks functionality with existing code? |
|
Yeh, that change in behaviour was a breaking change that was reverted since it broke stuff. |
|
Ok, thanks for the info. But just to confirm, the "return $result ?? 0;" was omitted on purpose from the reverted changes, as all the other changes for that commit were reverted back from what I can see with the rest of the code except for that line? Sorry to double check, it's just I want to make sure before I go through and change our project to support non-numeric return values on the sum function. Thanks for you help. |
|
Yes, we intentionally omitted this because the result can be non-numeric, so in those cases summing nothing cannot just default to the additive identity. |
|
Ok, thanks for confirming that for me. |
|
@GrahamCampbell Request #15345 seems to have applied the change I pushed in this request, (although in an alternate way). I have already made the changes to my code to work around the changed return type which you said would be staying. Could you please confirm why this functionality has now been put back as I had originally attempted and if it is going to stay this way? |
A change to the query builder sum function introduced on revert #14994 presents an issues where the sum function would return values other than of numeric type. It is my understanding that the sum() function should always return a numeric type, as before it used to perform a simple return 0 if result was false.