Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3] Fire / check queue looping event before running daemon #15290

Merged

Conversation

djtarazona
Copy link
Contributor

@djtarazona djtarazona commented Sep 5, 2016

After upgrading to Laravel 5.3, I've noticed the queue looping event (illuminate.queue.looping) no longer fires. It looks like the queue worker never fires the event. See daemonShouldRun() in 5.2 vs 5.3.

This PR reverts to the 5.2 functionality. I'm not sure if this would be considered a breaking change as the deamon will stop if a listener returns false to the illuminate.queue.looping event. This is the functionality in 5.2 and users / packages may expect 5.3 to behave the same way. On the other hand, if this is considered a breaking change, perhaps we can just fire the illuminate.queue.looping event without it having an effect on whether or not the daemon will run.

The looping event listener is presented in contracts / classes such as Illuminate\Contracts\Queue\Monitor and Illuminate\Queue\QueueManager, therefore I assume this issue of it not being fired at all should be fixed.

@GrahamCampbell
Copy link
Member

I think this was removed on purpose?

@taylorotwell taylorotwell merged commit 6a766e9 into laravel:5.3 Sep 6, 2016
@djtarazona djtarazona deleted the feature/fire-queue-looping-event branch September 6, 2016 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants