Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.3] Add split method to collection class #15302

Merged
merged 6 commits into from
Sep 6, 2016
Merged

[5.3] Add split method to collection class #15302

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ff03fb6
add split function to collection
freekmurze Sep 6, 2016
044c392
fix nitpicks
freekmurze Sep 6, 2016
e7f64ce
fix cs
freekmurze Sep 6, 2016
f9e67a7
more cs fixes
freekmurze Sep 6, 2016
f159dc9
moar cs
freekmurze Sep 6, 2016
baf09ec
return new instance
freekmurze Sep 6, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions src/Illuminate/Support/Collection.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -920,22 +920,22 @@ public function slice($offset, $length = null)
return new static(array_slice($this->items, $offset, $length, true));
}

/**
* Split a collection into a certain number of groups.
*
* @param int $numberOfGroups
* @return static
*/
public function split($numberOfGroups)
{
if ($this->isEmpty()) {
return $this;
}

$groupSize = ceil($this->count() / $numberOfGroups);

return $this->chunk($groupSize);
}
/**
* Split a collection into a certain number of groups.
*
* @param int $numberOfGroups
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I said a missing space, I really did mean exactly one space was missing. :trollface:

Please put exactly two spaces inbetween int and $.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, my apologies for all the trouble.

* @return static
*/
public function split($numberOfGroups)
{
if ($this->isEmpty()) {
return $this;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should return a new instance here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup

}

$groupSize = ceil($this->count() / $numberOfGroups);

return $this->chunk($groupSize);
}

/**
* Chunk the underlying collection array.
Expand Down