[5.3] Notifications id column type #15719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -13,7 +13,7 @@ class CreateNotificationsTable extends Migration | |||
| public function up() | |||
| { | |||
| Schema::create('notifications', function (Blueprint $table) { | |||
| $table->string('id')->primary(); | |||
| $table->char('id', 36)->primary(); | |||
| $table->string('type'); | |||
There was a problem hiding this comment.
Or couldn't you do:
$table->uuid('id')->primary();There was a problem hiding this comment.
@ryanwinchester that's will be even better because it will use Postgres & MsSql native types then.
|
Updated commit with @ryanwinchester proposal. Using UUID type for notification id column. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because notifications
idcolumn using UUID as primary key and it's length is always fixed wouldn't it be better to useCHAR(36)type instead ofVARCHAR(255)?Updated. Using
UUIDtype now.