[5.3] Cleanup route:list command. #15802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garygreen
force-pushed
the
cleanup-route-list
branch
from
8aad0af
to
d978cbb
Compare
GrahamCampbell
changed the title
ntzm
reviewed
Oct 7, 2016
| $results[] = Arr::get($middleware, $data['middleware'], $data['middleware']); | ||
| foreach ($middlewares as $i => $middleware) { | ||
| if ($middleware instanceof Closure) { | ||
| $middlewares[$i] = 'Closure'; | ||
| } | ||
| } |
There was a problem hiding this comment.
Don't know what the standards are for Laravel, but I (personally) would rewrite this with references:
foreach ($middlewares as &$middleware) {
if ($middleware instanceof Closure) {
$middleware = 'Closure';
}
}
|
Nice, thanks. Changed over the loop to use a collection->map operation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry about last PR. Was an oversight on my behalf for the new closure-style middlewares. I've tested this with closures, single function controllers, all working.
With this PR you'll see
Closurein the middleware list, so at least you know some kind of middleware is being registered in controllers, if applicable.