Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3] Fix match only APP_KEY in replace #17151

Merged
merged 2 commits into from
Jan 8, 2017
Merged

[5.3] Fix match only APP_KEY in replace #17151

merged 2 commits into from
Jan 8, 2017

Conversation

TheoKouzelis
Copy link
Contributor

@TheoKouzelis TheoKouzelis commented Jan 5, 2017

Changed str_replace to preg_replace to ensure no clashes with other environment variables.


Closes #17140.

TheoKouzelis and others added 2 commits January 4, 2017 23:52
Changed str_replace to preg_replace to ensure no clashes with other
environment variables
@GrahamCampbell GrahamCampbell changed the title Fix issue #17140 match only APP_KEY in replace [5.3] Fix match only APP_KEY in replace Jan 5, 2017
@taylorotwell taylorotwell merged commit 53cc628 into laravel:5.3 Jan 8, 2017
$escapedKey = preg_quote('='.$this->laravel['config']['app.key'], '/');

return "/^APP_KEY$escapedKey/m";
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not read nice to me 😕

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there anything you would recommend to make it read better?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a quick PR: #17226

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR and the code review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants