[5.3] Fix match only APP_KEY in replace #17151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed str_replace to preg_replace to ensure no clashes with other environment variables
GrahamCampbell
changed the title
tillkruss
reviewed
Jan 8, 2017
| $escapedKey = preg_quote('='.$this->laravel['config']['app.key'], '/'); | ||
|
|
||
| return "/^APP_KEY$escapedKey/m"; | ||
| } |
There was a problem hiding this comment.
This does not read nice to me 😕
There was a problem hiding this comment.
Is there anything you would recommend to make it read better?
There was a problem hiding this comment.
I made a quick PR: #17226
There was a problem hiding this comment.
Thanks for the PR and the code review.
tillkruss
added a commit
to tillkruss/framework
that referenced
this pull request
Jan 9, 2017
This was referenced Jan 9, 2017
taylorotwell
pushed a commit
that referenced
this pull request
Jan 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed str_replace to preg_replace to ensure no clashes with other environment variables.
Closes #17140.