Make make:model -fa behave correctly #19985
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, invoking
make:model -fa Car
creates the factory classCarFactory.php
, which ultimately createsApp\CarFactory::class
.So, it wants to create itself instead of the corresponding model.
To fix this, i've added an optional argument
model
tomake:factory
, which specifies the model to create.Further,
make:model -fa
now callsmake:factory
with the correct arguments.Let me now what you think.
Happy crafting 🔨