Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply fixes from StyleCI #20174

Merged
merged 1 commit into from
Jul 19, 2017
Merged

Apply fixes from StyleCI #20174

merged 1 commit into from
Jul 19, 2017

Conversation

taylorotwell
Copy link
Member

This pull request applies code style fixes from an analysis carried out by StyleCI.


For more information, click here.

[ci skip] [skip ci]
@taylorotwell taylorotwell merged commit a201a7f into validation-responses Jul 19, 2017
@taylorotwell taylorotwell deleted the analysis-zYMkrG branch July 19, 2017 20:47
taylorotwell added a commit that referenced this pull request Jul 19, 2017
* Unify validation exception formatting.

This unifies all validation error formatting into the exception handler
and out of Form Request. “Don’t Flash” is typically a global concept
that always applies to a list of fields for all pages in the
applications, so seemed to make sense to specify in one place instead
of each form.

Total control of the Form Request error response can still be gained by
overriding failedValidation and throwing a HttpResponseException with
whatever response you want.

* Apply fixes from StyleCI (#20174)

* shorten method call

* remove old test

* Apply fixes from StyleCI (#20175)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant