[5.5] Supporting Laravel-Mix PR #1246, HMR w/ different Hosts and Ports #21545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR changes the 'mix' helper function to take URLs coming from the hot file. This feature is fully backwards compatible. Supporting Laravel-Mix Pull Request #1246, allowing Hot Module Reloading with custom hosts and ports Do not merge straight away, awaiting reply of laravel-mix/laravel-mix#1246 Let me know if you require tests
tillkruss
changed the title
|
Submit this if Jeffrey approves the change on that side. Until then, there is nothing I can do. |
|
No worries, will do |
|
Continued on here: #22826 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the 'mix' helper function to take URLs coming from the hot file. This feature is fully backwards compatible.
Supporting Laravel-Mix Pull Request laravel-mix/laravel-mix#1246, allowing Hot Module Reloading with custom hosts and ports
Please don't merge straight away, I'm awaiting a reply to laravel-mix/laravel-mix#1246
Let me know if you require tests for the code change