[5.5] Do not continue checking APP_ENV if environment file path has being set
#22753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… successfully with `--env` option. Signed-off-by: tianhe1986 <w1s2j3229@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is a very interesting case our team just encountered.
There are two files,
.env.localand.env.testingin the project. And in a developing server, it addsexport APP_ENV=localin /etc/profile to define the environment.One of team member copied
.env.localto.env.testing.local. Then another person run a command with testing environment usingand found the result was not as expected.
After setting environment file path
.env.testingwith--envoption, it continued to checking the globalAPP_ENVdefinition and tried to set the file path.env.testing.localagain. At last, it was the later file being loaded.It may be a rare case, however, I think this PR is mainly meaning "--env option has higher priority than the global definition".