Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.8] Add some Relations, BelongsToOne, BelongsToThrough, HasOneThrough, MorhpToOne #25083

Closed
wants to merge 1 commit into from

Conversation

frdteknikelektro
Copy link

This relations has been come up for wanted feature in this repo issue.

@GrahamCampbell GrahamCampbell changed the title Add some Relations, BelongsToOne, BelongsToThrough, HasOneThrough, MorhpToOne [5.8] Add some Relations, BelongsToOne, BelongsToThrough, HasOneThrough, MorhpToOne Aug 4, 2018
@taylorotwell
Copy link
Member

I am closing this pull request because it lacks sufficient explanation, tests, or both. It is difficult for us to merge pull requests without these things because the change may introduce breaking changes to the framework.

Feel free to re-submit your change with a thorough explanation of the feature and tests - integration tests are preferred over unit tests. Please include it's benefit to end users; the reasons it does not break any existing features; how it makes building web applications easier, etc.

Thanks!

taylorotwell pushed a commit to illuminate/database that referenced this pull request Oct 11, 2018
This commit adds the Eloquent HasOneThrough relationship. This will allow for easy linking to deeper nested models and easy eager loading of them.

Many thanks to @frdteknikelektro and his original PR which really was most of the work: laravel/framework#25083
@ankurk91
Copy link
Contributor

If someone is looking for these relationships then
https://github.com/staudenmeir/belongs-to-through
https://github.com/ankurk91/laravel-eloquent-relationships

@raiika
Copy link

raiika commented Aug 13, 2019

does no one continue this PR ? The BelongsToOne is somewhat useful for me right now.

@localusercamp
Copy link
Contributor

BelongsToOne is absolutely nuts!
It MUST be in the framework core!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants