Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Throw RouteNotFoundException instead of InvalidArgumentException #29861

Conversation

amaelftah
Copy link
Contributor

instead of using InvalidArgumentException when route is not defined . we will throw symfony RouteNotFoundException . same as symfony MethodNotAllowedHttpException in Route Collection

that will help further in identifying the exception for more ideas . for example in ignition.

@GrahamCampbell
Copy link
Member

If RouteNotFoundException doesn't extend InvalidArgumentException, then this is breaking, and will need to go to the 7.x branch instead please.

@amaelftah
Copy link
Contributor Author

@GrahamCampbell it extends InvalidArgumentException

@driesvints
Copy link
Member

@taylorotwell @Te7a-Houdini seems to be correct. Re-opening this for you to review.

@driesvints driesvints reopened this Sep 5, 2019
@taylorotwell taylorotwell merged commit 4cc87e6 into laravel:6.x Sep 5, 2019
amaelftah referenced this pull request in facade/ignition Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants