Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.x] ValidatesAttributes::validateUrl use Symfony/Validator 5.0.7 regex #32315

Merged
merged 1 commit into from
Apr 9, 2020
Merged

[6.x] ValidatesAttributes::validateUrl use Symfony/Validator 5.0.7 regex #32315

merged 1 commit into from
Apr 9, 2020

Commits on Apr 9, 2020

  1. ValidatesAttributes::validateUrl use Symfony/Validator 5.0.7 regex 

    The regex used by url validation logic was previously derived from version
2.7.4 of Symfony Validator component. As it turns out, old regex had a bug
where it wouldn't accept urls where domain was a hostname ending with a digit.
As such, the urls like http://domain1/ would be considered as invalid.

To fix this issue I've updated \Illuminate\Validation\Concerns\ValidatesAttributes::validateUrl
method using regex derived from version 5.0.7 of the Symfony Validator component.
To make sure that the fix works, new test cases were also added.
    @bsacharski
    bsacharski committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    af6dcf3 View commit details
    Browse the repository at this point in the history