[6.x] Correct implementation of float casting comparison #33322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamCampbell
force-pushed
the
float-cast-fix
branch
from
68ce6ce
to
3b18fc0
Compare
GrahamCampbell
force-pushed
the
float-cast-fix
branch
from
3b18fc0
to
0623245
Compare
|
// cc @CraigHarley |
CraigHarley
approved these changes
Jun 25, 2020
|
With this change, if you have a decimal column set to null, and try to update it to 0.0, it will fail to update because So it's currently impossible to update a null column to a 0.0 value. |
|
I believe the $attribute is checked as null, not the $original. In this scenario $attribute is 0.0 and $original is null. It won't update in that case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.