[8.x] Guess the model name when using the make:factory command #34373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| : $rootNamespace.$model; | ||
| return class_exists($rootNamespace.$model) | ||
| ? $rootNamespace.$model | ||
| : $rootNamespace.'Models\\'.$model; |
There was a problem hiding this comment.
This entire change doesn't make sense I don't think. For most generator commands it's going to cause unexpected behavior.
|
any reason why you did not go with throwing an exception if models don't exist? - I am trying to work out why having a default arbitrary model would be the way to go here. 😃 |
|
@gocanto The model could be somewhere else, if it's in a default location then they will get the name autocompleted, if not they can add it manually. |
sileence
force-pushed
the
make_factory_guess_model_name
branch
from
63462fe
to
f1b98bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
php artisan make:factory Professionwill attempt to find theProfessionmodel inapp/orapp/Models.If the model is found then the previous command will be the equivalent of typing:
php artisan make:factory Profession --model=ProfessionIf the model is not found in the models directory (either
app/Modelsorapp/) then: the defaultapp\Models\Modelwill be used if theapp/Modelsdirectory exists, otherwiseapp\Modelwill be used.