Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed redundant database selection query #34389

Closed
wants to merge 1 commit into from
Closed

Removed redundant database selection query #34389

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/Illuminate/Database/Connectors/MySqlConnector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,6 @@ public function connect(array $config)
// connection's behavior, and some might be specified by the developers.
$connection = $this->createConnection($dsn, $config, $options);

if (! empty($config['database'])) {
$connection->exec("use `{$config['database']}`;");
}

Comment on lines -26 to -29
Copy link
Contributor

@mfn mfn Sep 17, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the initial implementation I dug out, there is a comment which has been removed over time (did not check why), but I guess it makes sense to check the mentioned case before fiddling around here => c203b02#diff-907ccb2ad354af6868ebb5618f2da86bR22-R23

See also #4138

$this->configureIsolationLevel($connection, $config);

$this->configureEncoding($connection, $config);
Expand Down