New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] Allow dynamic factory methods to obey newFactory method on model #34492

Merged

taylorotwell merged 2 commits into laravel:8.x from btaskew:dynamic_factory_methods_obey_new_factory_method

Sep 24, 2020

Contributor

btaskew commented Sep 23, 2020

PR is for issue #34490

Benefit is that models that have to define a factory via the newFactory method can utilise the magic factory methods for has and for.


          Allow dynamic factory methods to obey newFactory method on model

6321ae0

Member

taylorotwell commented Sep 23, 2020 •

edited

Loading

What if the class isn't using that trait? Should you check if the method exists first?


          Check for method existence

70a73ab

taylorotwell merged commit 70a73ab into laravel:8.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet