[8.x] Fix router inconsistency for namespaced route groups #34793
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following my previous PR which was rejected #34784, I wanted to shed more light on the situation.
From laravel 5.6 #24385 til laravel 8.x we can define our routes like this:
and it works. The
'Whatever'
namespace does NOT get appended, since we have used thearray notation
to refer to the controller method.All and all, the order in which the
middleware(...
andget(...
methods are called in the chain, should have NO effect on their behavior or how they accept parameters. (according to the docs.)But if we only reverse the order of
get
andmiddleware
method calls in the example above suddenly the'Whatever'
namespace gets appended to the controller and stops working.and that is definitely wrong.