[6.x] Provisional support for PHP 8.0 #34884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Dries Vints <594614+driesvints@users.noreply.github.com> Co-Authored-By: Taylor Otwell <taylor@laravel.com>
|
I have not added PHP 8.0 to the builds here, since it is not useful, in particular when merging upwards to Laravel 8 where composer installs will fail due to faker. We can track the PHP 8.0 test status over on the other PR, when we rebase. |
driesvints
approved these changes
Oct 19, 2020
stancl
reviewed
Oct 20, 2020
bytestream
reviewed
Oct 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to get the 6.x branch ready for PHP 8.0, without official support yet. Official support will come in #33388 once all the outstanding issues are resolved. Most notably, Doctrine DBAL and Faker remain blockers, and possibly AWS SDK, since Amazon have made no effort here. All the effort has come from the OSS community on their dependencies.