Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] Add regex registration method to check alphanumeric route parameters. #35154

Merged
merged 1 commit into from
Nov 9, 2020
Merged

[8.x] Add regex registration method to check alphanumeric route parameters. #35154

merged 1 commit into from
Nov 9, 2020

Conversation

amitmerchant1990
Copy link
Contributor

Inspired by #34997, This PR adds a (supposedly) missing whereAlphaNumeric regex registration method to check alphanumeric route parameters.

@taylorotwell taylorotwell merged commit b31f88f into laravel:8.x Nov 9, 2020
@LucaRed
Copy link
Contributor

LucaRed commented Nov 11, 2020

What about allowing dashes and calling it whereSlug? This would match what Str::slug() returns.

@amitmerchant1990 amitmerchant1990 mentioned this pull request Nov 13, 2020
Closed
This was referenced Nov 25, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amitmerchant1990 @LucaRed @taylorotwell