Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Fix Application flush method #35482

Merged
merged 1 commit into from
Dec 4, 2020

Conversation

imanghafoori1
Copy link
Contributor

@imanghafoori1 imanghafoori1 commented Dec 3, 2020

Following a recent PR #35228 on Container class which adds a couple of new properties,
it seems that these properties are forgotten to be included in the flush method on the subclass (Application),

Note: Obviously, the application object should get reset completely after the flush is called,
so this is actually a "bug fix", not a performance improvement like in #30065

@imanghafoori1 imanghafoori1 changed the title [8.x] Fix application flush [8.x] Fix Application flush method Dec 3, 2020
@taylorotwell taylorotwell merged commit b09f778 into laravel:8.x Dec 4, 2020
@imanghafoori1 imanghafoori1 deleted the fix_app_flush branch December 4, 2020 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants