Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Fix passing model instances to factories #35541

Merged
merged 1 commit into from
Dec 8, 2020
Merged

[8.x] Fix passing model instances to factories #35541

merged 1 commit into from
Dec 8, 2020

Conversation

bakerkretzmar
Copy link
Contributor

This PR fixes the new feature introduced in #35494 which allows passing model instances to factories. We missed one place in each method where the model/factory instance needs to be treated differently depending on its type.

@bakerkretzmar bakerkretzmar changed the title Fix passing model instances to factories [8.x] Fix passing model instances to factories Dec 8, 2020
@bakerkretzmar
Copy link
Contributor Author

I'll come back to this asap and add tests to cover this specific case, just wanted to get the fix in quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants