Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Fix report method for ViewException #36110

Merged
merged 3 commits into from
Feb 1, 2021
Merged

Conversation

driesvints
Copy link
Member

@driesvints driesvints commented Feb 1, 2021

I didn't take into account that the report method can resolve dependencies from the container. This PR fixes just that.

It also fixes the incorrect return types now present on the report method's DocBlock return annotations.

Fixes #36108 #36109

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ViewExceptions will never be logged ViewException does not provide dependencies to the wrapped report method
3 participants