[8.x] Adds a collect method to the HTTP Client response

[lukeraymonddowning]

Hi all,

This PR is a DX improvement for retrieving HTTP REST responses as a Collection when using the HTTP Client.

Here's an example:

Http::get("https://api.foo.bar/users")->collect();

This is syntactical sugar for:

collect(Http::get("https://api.foo.bar/users")->json());

I feel that this allows for a more declarative experience, especially as more often than not the next step is to map the response into another object.

return Http::get("https://api.foo.bar/users")
    ->collect()
    ->map(fn($data) => new DataObject($data['name'], $data['description']));

Would be glad to hear your thoughts!

Thanks for all the hard work,
Luke

[BrandonSurowiec]

Neat idea! What about accepting a $key = null param on collect() to pass through to the ->json() method? Or does that look out of place on a collect method?

return Http::get("https://api.foo.bar/users")
    ->collect('activeUsers')
    ->map(fn($data) => new DataObject($data['name'], $data['description']));

[lukeraymonddowning]

Neat idea! What about accepting a $key = null param on collect() to pass through to the ->json() method? Or does that look out of place on a collect method?

return Http::get("https://api.foo.bar/users")
    ->collect('activeUsers')
    ->map(fn($data) => new DataObject($data['name'], $data['description']));

I like it personally. I think it makes sense if you have a data or results node on the response, as per your example. I'm happy to remove if others think otherwise. I think in this context it works well.

"Collect the activeUsers in the response"