Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] Fix replacing required :input with null on PHP 8.1 #36622

Merged
merged 1 commit into from
Mar 17, 2021
Merged

[8.x] Fix replacing required :input with null on PHP 8.1 #36622

merged 1 commit into from
Mar 17, 2021

Commits on Mar 16, 2021

  1. Fix replacing required :input with null on PHP 8.1 

    Fixes an issue where data lacking one or more of the fields under
validation will cause tests to fail with an `ErrorException`.

That exception is a PHP deprecation warning triggered by the call to
`str_replace()` inside `replaceInputPlaceholder()`, which assumes the
value returned from `getDisplayableValue()` will always be a string.
    @dshoreman
    dshoreman committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    dd746f9 View commit details
    Browse the repository at this point in the history