[8.x] Fix for #34592 artisan schema:dump error #36698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driesvints
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34592
In Alpine Linux the mysql-client package (containing mysqldump and mysql CLI) is an alias for the MariaDB version of the CLI tools. The MariaDB version of mysqldump doesn't support the set-gtid-purged parameter, so the command fails in cases where the MariaDB CLI tool is being used to access to MySQL database connection. The current "isMaria" function only supports cases where the connection is to a MariaDB database.
This fix uses the same approach used for a similar issue with the column-statistics parameter: if there is an error related to the parameter it is removed and the command retried.