Add phpredis serialization and compression config support #36791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamCampbell
requested changes
Mar 28, 2021
| ]))->connection(); | ||
| } | ||
|
|
||
| // TODO: Uncomment after https://github.com/phpredis/phpredis/issues/1939 |
There was a problem hiding this comment.
Marking as draft, due to this blocker.
|
Please send this in when the PR is finished and without TODO's. Thanks |
|
Thanks, will first try to fix phpredis, if thats not possible short term, I will exclude lz4 support. |
|
@TheLevti any news on this? |
I am waiting for phpredis to release 5.3.5 |
@TheLevti 5.3.5 is released I see https://github.com/phpredis/phpredis/releases/tag/5.3.5 |
Thanks for the update, will re-open my pull request soon. |
|
#40282 follow up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request allows the framework user to configure phpredis (https://github.com/phpredis/phpredis) serialization and compression options right in the config instead of the need to overwrite the service provider or a custom driver.
Supported serializers:
Supported compressors:
I did here similar changes to what #31262 tried to do, just without the for me not yet understandable other adjustments to some of the redis functions. Also added tests for different compression algorithms.
Note: My first attempt was to always serialize + compress the passed arguments to eval, but then later decided to let the user take care of this as we can not know what kind of lua script he wants to execute and whether all arguments are expected to be serialized/compressed. Instead I provided a helper method on the
PhpredisConnectionclass that the user may use. In addition I refactored the previous phpredis lock support (#36337) for these functionalities to use this new helper method.