[8.x] Fix escaping within quoted strings #36893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jasonmccreary seems this breaks some other tests. |
driesvints
changed the title
|
@driesvints looking at these failures now. A few already appear to be on |
jasonmccreary
force-pushed
the
fix-string-escaping
branch
from
4773a34
to
b0f9dc6
Compare
|
All green. However, I still have my doubts about this regex overall. 😬 |
|
I'm very tempted to revert everything this whole GitHub issue triggered. Blade has been around for 10 years now and generally been fine and this has triggered a string of PRs and new issues 🤷 |
|
Not making anymore changes for now. |
|
Eh, I will merge this - but if any more issues pop up we will be reverting everything to how it was a few versions ago. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a patch for the issue noted in 36843 to allow for escaping within quoted strings.
While this handles this common case, there may be other escape sequences it does not handle. Those will likely be beyond the abilities of a single pass regular expression.