[8.x] Allow symlink recreation in storage:link command #37501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driesvints
reviewed
May 27, 2021
Co-authored-by: Dries Vints <dries@vints.io>
|
|
||
| foreach ($this->links() as $link => $target) { | ||
| if (file_exists($link)) { | ||
| if (file_exists($link) && ! (is_link($link) && $force)) { |
There was a problem hiding this comment.
Can you rewrite this conditional? It is hard to read.
driesvints
reviewed
May 27, 2021
| * @param bool $force | ||
| * @return bool | ||
| */ | ||
| protected function removableSymlink(string $link, bool $force): bool |
There was a problem hiding this comment.
Boolean methods often are prefixed with is or has:
Suggested change
| protected function removableSymlink(string $link, bool $force): bool | |
| protected function isRemovableSymlink(string $link, bool $force): bool |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows symlinks to be overridden when
--forceoption is specified to thestorage:linkcommand. Existing behavior was not changed and regular files won't be replaced with symlinks.This could come helpful:
Currently the only solution to these cases is to manually remove the existing symlinks