[6.x] Fixes Query Builder to only cast integer when given other than null
#39644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
crynobone
force-pushed
the
patch-limit
branch
from
424b1bf
to
209c12f
Compare
taylorotwell
added a commit
that referenced
this pull request
Nov 17, 2021
* wip * [6.x] Fixes Query Builder to only cast integer when given other than `null` (#39644) * Add failing tests Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com> * Only cast integer when given other than null Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com> * Improve tests Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com> Co-authored-by: Taylor Otwell <taylor@laravel.com> Co-authored-by: Mior Muhammad Zaki <crynobone@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regression bug was introduced in v6.20.39 and v8.71.0
Fixes laravel/nova-issues#3637
Signed-off-by: Mior Muhammad Zaki crynobone@gmail.com