Fix race condition in locks issued by the file cache driver #43661
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes issue #43627.
TLDR:
Atomic locks issued by FileStore or other stores that use the HasCacheLock trait have a race condition when the lock timeout is zero (the default). This can cause multiple processes to concurrently enter a critical section protected by the lock.
The old lock implementation would do a non-atomic
get
andput
when the lock timeout is less than or equal to zero and an atomicadd
otherwise. The new implementation always does an atomicadd
. This change only breaks code that incorrectly implemented their cache store, i.e. theiradd
method cannot handle lock timeouts less or equal to zero.