Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[11.x] Fix: Removed TTY mode to resolve Windows compatibility issue #50495

Merged
merged 7 commits into from
Mar 13, 2024
+12 −4
Merged

[11.x] Fix: Removed TTY mode to resolve Windows compatibility issue #50495

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2aad3e2
Removed TTY mode on Windows in broadcasting node dependency installation
yourchocomate Mar 13, 2024
52a860f
Update src/Illuminate/Foundation/Console/BroadcastingInstallCommand.php
driesvints Mar 13, 2024
b93af05
Update src/Illuminate/Foundation/Console/BroadcastingInstallCommand.php
driesvints Mar 13, 2024
59ca0b6
[11.x] Fix: synced with checker in broadcast installation
yourchocomate Mar 13, 2024
9ae6cec
Update src/Illuminate/Foundation/Console/stubs/echo-bootstrap-js.stub
driesvints Mar 13, 2024
dd8e3bb
Update src/Illuminate/Foundation/Console/stubs/echo-bootstrap-js.stub
driesvints Mar 13, 2024
d70adaa
Update BroadcastingInstallCommand.php
taylorotwell Mar 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions src/Illuminate/Foundation/Console/BroadcastingInstallCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,9 +168,17 @@ protected function installNodeDependencies()
];
}

Process::command(implode(' && ', $commands))
->path(base_path())
->tty(true)
->run();
$command = Process::command(implode(' && ', $commands))
->path(base_path());

if (! windows_os()) {
$command->tty(true);
}

if ($command->run()->failed()) {
$this->components->warn("Node dependency installation failed. Please run the following commands manually: \n\n" . implode(" && ", $commands));
} else {
$this->components->info("Node dependencies installed successfully.");
}
}
}
Loading