Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.x] Add --without-reverb and --without-node arguments to install:broadcasting command #50662

Merged
merged 4 commits into from
Mar 19, 2024
Merged

[11.x] Add --without-reverb and --without-node arguments to install:broadcasting command #50662

merged 4 commits into from
Mar 19, 2024

Conversation

duncanmcclean
Copy link
Contributor

This pull request adds two additional arguments to the install:broadcasting command.

They allow developers to skip the "Install Reverb" and "Install Node dependencies" prompts when scaffolding the rest of the broadcasting stuff.

Use Case

We have an optional "Collaboration" feature in our package. During the setup command, we give developers the option of which broadcasting connection they wish to use (eg. Reverb / Pusher / etc).

However, since we run install:broadcasting during the setup command, it'll install Reverb even if the developer picked to use Pusher or another driver.

It's a similar-ish situation with the Node dependencies. Since our package bundles with Laravel Echo, our developers don't need the echo.js file (& it's dependencies) added to their project.

@taylorotwell taylorotwell merged commit 2e3581d into laravel:11.x Mar 19, 2024
28 checks passed
@duncanmcclean duncanmcclean deleted the add-arguments-for-installing-broadcasting-without-reverb-or-npm-dependencies branch March 19, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants