[11.x] Apply default timezone when casting unix timestamps #50751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@daniser can I confirm with you that you're using a different timezone in php.ini than UTC? |
|
@driesvints yes, both in |
|
I confirm this change will make the method behave like in Carbon v2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Carbon 3 no longer apply default timezone while creating from unix timestamp
Laravel 11 supports both Carbon 2 and 3. I think it should behave the same regardless of installed Carbon version.
We may switch to the new behaviour in the next major version given that we'll drop support for Carbon 2.