[10.x] Prevent Redis connection error report flood on queue worker #50812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasus
changed the title
|
Bravo! I have experienced this many times. Let's hope I never will see it again :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given setup of Laravel with Horizon, using Redis as a queue driver via phpredis.
In case of connection issue with Redis, every running worker starts continuously reporting RedisException, which leads to a large flood of errors into the error reporting system.
I believe it has to be prevented by
Illuminate/Queue/Worker.php:372call of$this->stopWorkerIfLostConnection($e);but it doesn't happen for phpredis exception.