[11.x] Improves serve Artisan command
#50821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes: #50033, #50041, #48924, and honestly, is is an overall improvement to any other PR that complained about
artisan servethrowing exceptions after being used for a while.We've applied a technique I picked up last week while working on Pint, which is to only consider the output "finished" when there's a line separator.
So, if a process gives the following output:
I will actually wait for the
0 /fooon the second time the output closure is executed, before actually displaying the output referring to that line.I've stress-tested this PR using Pest's stressless plugin, with and without the
PHP_CLI_SERVER_WORKERSenvironment variable, and not a single request was lost while serving a regular Laravel application with Jetstream.