[11.x] Simplify condition structure and add @throw
to docblock for resolve method
#50863
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
resolve
method to exception handling by includingRuntimeException
in its throws clause within the doc block and simplifying the conditional structure.We encounter the following code snippet in the resolve method:
Therefore, we can add the
@throws RuntimeException
to the doc blockSimplifying the conditional structure
In the above code, if the first if statement is executed, the else part will never be executed because a value is returned in this if, the same scenario happens in the else part as well. Therefore, we can simplify it a bit: