Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.x] Remove redundant getDefaultNamespace method in some classes (class, interface and trait commands) #50880

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

saMahmoudzadeh
Copy link
Contributor

In the following classes:

  • ClassMakeCommand.php
  • InterfaceMakeCommand.php
  • TraitMakeCommand.php

Since the method getDefaultNamespace exists exactly in the parent class, it is unnecessary. Overrides should only be applied when they differ from the parent class ( OOP principle)

Copy link

github-actions bot commented Apr 1, 2024

Thanks for submitting a PR!

Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface.

Pull requests that are abandoned in draft may be closed due to inactivity.

@saMahmoudzadeh saMahmoudzadeh marked this pull request as ready for review April 1, 2024 22:00
@taylorotwell taylorotwell merged commit cc4dde4 into laravel:11.x Apr 1, 2024
30 checks passed
@saMahmoudzadeh saMahmoudzadeh deleted the fix/generator-commands branch April 1, 2024 22:38
@saMahmoudzadeh
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants