Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow sorting of route:list by multiple column/factors using a comma #50998

Merged
merged 6 commits into from
Apr 10, 2024
Merged

Allow sorting of route:list by multiple column/factors using a comma #50998

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1d69d95
feat: allow route:list sorting bymultiple column factors using a comma
fredbradley Apr 10, 2024
38ddba7
fix: code indentation
fredbradley Apr 10, 2024
598aafd
fix: code indentation again to appease styleci
fredbradley Apr 10, 2024
1e9c99b
styleci: add line break before return statement
fredbradley Apr 10, 2024
a8709d7
refactor: use `collect` and `sortBy` methods regardless of using a co…
fredbradley Apr 10, 2024
09e6946
style: used pint to work out what the thing styleci was complaining a…
fredbradley Apr 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/Illuminate/Foundation/Console/RouteListCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,9 +157,13 @@ protected function getRouteInformation(Route $route)
*/
protected function sortRoutes($sort, array $routes)
{
return Arr::sort($routes, function ($route) use ($sort) {
return $route[$sort];
});
if (Str::contains($sort, ',')) {
$sort = explode(',', $sort);
}

return collect($routes)
->sortBy($sort)
->toArray();
}

/**
Expand Down