[11.x] Adds support for int
backed enums to implicit Enum
route binding
#51029
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request allows you to bind
int
backed enums to your routes.now, if we try to bind int backed enum to route, we are getting the error below :
With this PR we'll see:
There is a comment about why we didn't do it in the first place but I don't see any reason to not to try that.
We can skip checking the backed enum type in the ReflectionEnum part and validate all values via
collect($backedEnum::cases)->first()
without amatch
And also I've created a PR for the docs
Best.