Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.x] github actions: test mariadb very latest #51193

Closed
wants to merge 1 commit into from

Conversation

grooverdan
Copy link
Contributor

MariaDB Foundation produce a quay.io image off the latest RC branch. This included only reviewed and tested changes that developers consider finished.

To maintain compatibility with important ecosystem projects like Laravel, its important that Laravel's test suite be applied to this testing too. MariaDB would like to find out about any accidental incompatibilities before release for our mutual users' benefit.

announce doc: https://mariadb.org/new-service-quay-io-mariadb-foundation-mariadb-devel/
(and yes images have got a bit behind recently due to accidential builder change, but will be back soon).

MariaDB Foundation produce a quay.io image off the latest RC branch.
This included only reviewed and tested changes that developers consider
finished.

To maintain compatibility with important ecosystem projects like
Laravel, its important that Laravel's test suite be applied to this
testing too. MariaDB would like to find out about any accidental
incompatibilities before release for our mutual users' benefit.
@driesvints
Copy link
Member

driesvints commented Apr 24, 2024

I do get the sentiment behind the PR here but right now we're not doing this for any of the other engines either. If we do this I feel like we should do this for all of them or none.

Bit torn because this will increase our action count by another 5 checks that'll need to run on every PR. Wondering if it makes sense to add a different databases-nightly.yml action with these RC/nightly builds that only runs once during the day/night.

@Jubeki
Copy link
Contributor

Jubeki commented Apr 24, 2024

@driesvints I am also in favour of a nightly build, instead of running the tests on each PR.

Note: A quick search showed that MySQL, Postgres and MSSQL not really have "preview" images available or I just couldn't find them. (For MSSQL there is a tag 2022-preview-ubuntu-22.04 but not sure if that is the latest preview build)

@Jubeki
Copy link
Contributor

Jubeki commented Apr 24, 2024

@grooverdan an alternative is also, that you run the tests in your environment / repository and simply pull the default/latest laravel framework branch in.

You could then also experiment with different charsets e.g.

@grooverdan
Copy link
Contributor Author

I'm not familiar with other DB's offering a nightly binary/container either. Closest I've found is https://wiki.postgresql.org/wiki/PostgreSQL_Buildfarm_Howto with "Testing Additional Software", but it means hooking into their buildfarm and postgres compiling as well.

I have done the occasional 3rd party test like php in our environment (https://buildbot.mariadb.org/#/builders/237), I just struggle to refamiliarise myself with the build/test/framework when I need to correct test failures (as the build history shows).

Happy to summit a nightly github action.

Also could extend the existing MariaDB job with a second service on a different port like 3308 (with a port mapping) and having a second execute tests stage (33s) with DB_PORT=3308. Not sure if there is any parallelisation in the Initialize containers step but it could be up to 22 seconds again. Still this is saving 20 seconds on top a duplicated step like this PR. (Oh how I envy a 2 minute test suite 😃 )

@taylorotwell taylorotwell marked this pull request as draft April 25, 2024 14:20
@Jubeki
Copy link
Contributor

Jubeki commented Apr 26, 2024

@grooverdan I went ahead and created a nightly workflow. See #51218

(It is open to the Taylor / Laravel Team which one should be merged)

@driesvints
Copy link
Member

Gonna close this one in favour of #51218. Thanks @grooverdan!

@driesvints driesvints closed this May 3, 2024
@grooverdan
Copy link
Contributor Author

Thank you.

@grooverdan grooverdan deleted the mariadb_ci_verylatest branch May 3, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants