[10.x] Fix support for the LARAVEL_STORAGE_PATH env var (#51238) #51243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunglas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#48115 introduced a convenient environment variable to configure the storage path.
However, by default, PHP doesn't populate the
$_ENVsuperglobal indevandproductionmode: https://github.com/php/php-src/blob/ed916214c478da36d473d425ca30e2ce7c310e87/php.ini-production#L159-L160On the other hand, environment variables are always populated in the
$_SERVERsuperglobal (https://www.php.net/manual/en/ini.core.php#ini.variables-order).For its part https://github.com/vlucas/phpdotenv populates both
$_SERVERand$_ENV.This patch switches from
$_ENVto$_SERVER, which will help using Laravel in containerized environments, where.envfiles aren't used in production.