[11.x] Adding PasswordResetLinkSent event #51253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #51223, I have updated this PR to remove the use of the global
event()helper.This PR adds are new event called
PasswordResetLinkSent, which is triggered by thePasswordBrokerdirectly after the Notification is queued.We had a need for this ourselves, and this seemed to be the only missing event in the auth / reset chain, and seems like something that may be useful for others.
Note that it's possible to trigger your own event within the application layer at least a couple of different ways, using middleware or within a Notification event listener, but those solutions seem messy comparatively.
When looking at the other Auth related events already supported I think doing this natively makes sense.
Note: I decided not to trigger the event if $callback is passed in, since we will not know how this is handled within the callback.