[11.x] Add query method to UrlGenerator contract docblock #51515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
using phpdoc so it is not a breaking change
hjanos-bc
commented
May 20, 2024
crynobone
approved these changes
May 21, 2024
crynobone
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#51075 added the very useful query helper to UrlGenerator
Since the UrlGenerator contract does not have this method, IDEs and static analyzer tools cannot understand or autocomplete it.
Adding it to the interface would be considered a breaking change, so I am using phpdoc here, and it can be added to the contract in Laravel 12 if preferred.