Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[11.x] Fix type tests #51558

Merged
merged 1 commit into from
May 24, 2024
Merged

[11.x] Fix type tests #51558

merged 1 commit into from
May 24, 2024

Conversation

stayallive
Copy link
Contributor

@stayallive stayallive commented May 24, 2024 •
edited
Loading

Latest phpstan got smarter and #51557 has broken tests because of it. This fixes the tests with the latest version of phpstan.

See: https://github.com/phpstan/phpstan/releases/tag/1.11.2

@stayallive stayallive mentioned this pull request May 24, 2024
Closed
@stayallive
Copy link
Contributor Author

@driesvints here you go, test suite fixed, was not my PR 😄

@taylorotwell taylorotwell merged commit 022ebc9 into laravel:11.x May 24, 2024
30 checks passed
@stayallive stayallive deleted the fix-type-tests branch May 24, 2024 14:21
@driesvints
Copy link
Member

Thanks @stayallive 👍

@renovate renovate bot mentioned this pull request Jul 3, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stayallive @driesvints @taylorotwell